Repository navigation
Apply lazy key and value casts when reading with get - #67
Merged
Merged
Conversation
wolph
added a commit
that referenced
this pull request
Oct 29, 2026
With #67, get passed every key through the key cast, so get(None) or get('spam') on an int-keyed dict raised where dict.get returned the default. A key the cast rejects cannot have been stored, so get now looks it up as it is. get also read through __getitem__, which ran a subclass's __missing__ and stored its result, and its keyword parameters made a positional-only override of dict.get an incompatible override.
wolph
added a commit
that referenced
this pull request
Oct 29, 2026
Owner
|
Thank you for the fix and the thorough tests! I've made a few changes on top (54f4c10). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LazyCastedDict(int, int, {'1': '2'}).get('1')currently returnsNone, while the same indexed read returns2. Reading with the stored integer key instead returns the raw string'2'. Inheriteddict.get()bypasses both lazy casts.Implement
get()with the same key/value conversions as indexed reads. Missing defaults remain unchanged, stored values remain raw and each read casts them again. Conversion errors propagate, includingKeyErrorfrom a value caster; key casting runs once. Add the standard get overloads, regression tests and a class doctest.Two new regression methods fail before the fix. Full Python 3.10 and 3.12 suites: 373 passed, 5 optional timezone-data skips, 100% branch/statement coverage. Whole-project mypy, basedpyright and Pyrefly report no errors. Ruff lint and formatting of changed files, plus
git diff --check, pass. No matching open issue or PR found.AI assistance: OpenAI Codex (GPT-6). Original user request:
new 14ta koro aro(make 14 more new contributions). Diff inspection was automated; no human review or personal production usage is claimed.